Closing resolved good-first-issues

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Closing resolved good-first-issues

Tina Oberoi
Hi all,

I observed that there are many good-first-issues that are resolved but yet open. It would be a great help for new contributors if we could close them and label new good-first-issues (if not labelled already).

Thanks and Regards
Tina 

_______________________________________________
NumPy-Discussion mailing list
[hidden email]
https://mail.python.org/mailman/listinfo/numpy-discussion
Reply | Threaded
Open this post in threaded view
|

Re: Closing resolved good-first-issues

ralfgommers


On Fri, May 1, 2020 at 5:53 PM Tina Oberoi <[hidden email]> wrote:
Hi all,

I observed that there are many good-first-issues that are resolved but yet open. It would be a great help for new contributors if we could close them and label new good-first-issues (if not labelled already).

Hi Tina, thanks for pointing that out. I have added you to the triage team, so you are able to close issues that you already noticed are fixed. I'll have a look at labelling some new ones now.

Cheers,
Ralf


_______________________________________________
NumPy-Discussion mailing list
[hidden email]
https://mail.python.org/mailman/listinfo/numpy-discussion
Reply | Threaded
Open this post in threaded view
|

Re: Closing resolved good-first-issues

Tina Oberoi
In reply to this post by Tina Oberoi
Fri, 1 May 2020 18:05:14  Ralf Gommers <[hidden email]>
wrote:

>
> Hi Tina, thanks for pointing that out. I have added you to the triage team,
> so you are able to close issues that you already noticed are fixed. I'll
> have a look at labelling some new ones now.
 
These are the issues that have pull requests merged but still open, Please let me know if I am wrong else we can close these issues:

Thanks and Regards
Tina

_______________________________________________
NumPy-Discussion mailing list
[hidden email]
https://mail.python.org/mailman/listinfo/numpy-discussion
Reply | Threaded
Open this post in threaded view
|

Re: Closing resolved good-first-issues

mattip
Administrator

On 3/5/20 1:39 pm, Tina Oberoi wrote:

>
> These are the issues that have pull requests merged but still open,
> Please let me know if I am wrong else we can close these issues:
> - Issue #9476 <https://github.com/numpy/numpy/issues/9476>
> - Issue #2802 <https://github.com/numpy/numpy/issues/2802>
> - Issue #11875 <https://github.com/numpy/numpy/issues/11875>
> - Issue #13114 <https://github.com/numpy/numpy/issues/13114>
> - Issue #13758 <https://github.com/numpy/numpy/issues/13758>
>
> Thanks and Regards
> Tina
>

Tina it would be helpful to directly comment on the issues in question.
If you are unsure the issues are actually resolved, you can add a
comment  "Can we close this, probably resolved by ...". If you are sure
they are resolved, go ahead and close them with a message "Resolved by
...". If it appears they are too complicated for the "good first issue"
label, you can just remove the label.


Matti

_______________________________________________
NumPy-Discussion mailing list
[hidden email]
https://mail.python.org/mailman/listinfo/numpy-discussion
Reply | Threaded
Open this post in threaded view
|

Re: Closing resolved good-first-issues

ralfgommers


On Mon, May 4, 2020 at 8:40 AM Matti Picus <[hidden email]> wrote:

On 3/5/20 1:39 pm, Tina Oberoi wrote:
>
> These are the issues that have pull requests merged but still open,
> Please let me know if I am wrong else we can close these issues:
> - Issue #9476 <https://github.com/numpy/numpy/issues/9476>
> - Issue #2802 <https://github.com/numpy/numpy/issues/2802>
> - Issue #11875 <https://github.com/numpy/numpy/issues/11875>
> - Issue #13114 <https://github.com/numpy/numpy/issues/13114>
> - Issue #13758 <https://github.com/numpy/numpy/issues/13758>
>
> Thanks and Regards
> Tina

Thanks for this list Tina!


Tina it would be helpful to directly comment on the issues in question.
If you are unsure the issues are actually resolved, you can add a
comment  "Can we close this, probably resolved by ...". If you are sure
they are resolved, go ahead and close them with a message "Resolved by
...".

I agree with that advice, if it's clear-cut you can do this. Most cases were pretty complicated though to assess.

If it appears they are too complicated for the "good first issue"
label, you can just remove the label.

A request to maintainers as well: please keep "good first issue" for actually easy things. 3 of these were easy (one of which turned into a hard one during the conversation), but 2 were definitely not.

Cheers,
Ralf


_______________________________________________
NumPy-Discussion mailing list
[hidden email]
https://mail.python.org/mailman/listinfo/numpy-discussion